Updates to CEP27 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks awesome! Sorry for the petty mistakes :/ |
|
No worries! It is important to be particular here :) |
|
@scopatz So what's the next step? Is it ready to be a PR to the cyclus/cyclus.github.com? |
|
I am happy with it, if you are happy with it. The next step is to PR it into the mainline repo, as you say. Then also send it to cyclus-dev@googlegroups.com for discussion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jbae11 - Here are some proposed edits to CEP27. Merge if you agree, comment if you don't! :)