Skip to content

Conversation

chausner
Copy link
Contributor

@chausner chausner commented Apr 2, 2023

For CMAKE_INSTALL_* variables, GNUInstallDirs should be included, see https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html.

@jbaldwin
Copy link
Owner

jbaldwin commented Apr 2, 2023

Hey thanks for making a PR. Does anything in the readme need to be updated on installation with this change?

@chausner
Copy link
Contributor Author

chausner commented Apr 2, 2023

You're welcome! No changes are needed in the README.

@jbaldwin jbaldwin self-assigned this Apr 4, 2023
@jbaldwin jbaldwin merged commit 33a125f into jbaldwin:main Apr 4, 2023
@chausner chausner deleted the use-cmake-install-libdir branch April 4, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants