Skip to content

Clean: Fix MSVC compiler warning. #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2023
Merged

Clean: Fix MSVC compiler warning. #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6af42e
Clean: Fix MSVC compiler warning.
bjones1 Oct 18, 2023
8fe7539
Merge commit '398cc0c48592340da6175d0c6b90043937f9cf65' into fix-warning
bjones1 Oct 22, 2023
6be88c0
Fix: Use a static_assert instead of a constexpr.
bjones1 Oct 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions include/coro/ring_buffer.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,9 @@ class ring_buffer
};

/**
* @throws std::runtime_error If `num_elements` == 0.
* static_assert If `num_elements` == 0.
*/
ring_buffer()
{
if (num_elements == 0)
{
throw std::runtime_error{"num_elements cannot be zero"};
}
}
ring_buffer() { static_assert(num_elements != 0, "num_elements cannot be zero"); }

~ring_buffer()
{
Expand Down
5 changes: 0 additions & 5 deletions test/test_ring_buffer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,6 @@
#include <chrono>
#include <thread>

TEST_CASE("ring_buffer zero num_elements", "[ring_buffer]")
{
REQUIRE_THROWS(coro::ring_buffer<uint64_t, 0>{});
}

TEST_CASE("ring_buffer single element", "[ring_buffer]")
{
const size_t iterations = 10;
Expand Down