task promise use std::variant #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaldwin
force-pushed
the
issue-196/std-variant-for-task-promise
branch
from
8baac24 to
231a460
Compare
This is a step towards using a more modern container within the task promise and reduce some manual overhead around managing the unsigned char[] that would store the return value but retaining the benefits that that solution brought to the task's promise class. Closes #196
jbaldwin
force-pushed
the
issue-196/std-variant-for-task-promise
branch
from
231a460 to
b82003d
Compare
|
@a858438680 if you have some time I'd appreciate a review on this more modern take for the task optimizations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step towards using a more modern container within the task promise and reduce some manual overhead around managing the unsigned char[] that would store the return value but retaining the benefits that that solution brought to the task's promise class.
Closes #196