Re-work tls client to match openssl requirements #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSL_read_ex and SSL_write_ex need to be recalled with the same paramters if they return SSL_ERROR_WANT_READ|WRITE. This was left up to the user before.. which is cumbersome and not very intuitive. Now the send() and recv() functions on the net::tls::client are coro:task's so they can properly call SSL_read|write_ex as many times as required. They now also support a timeout since these calls could take longer than a traditional net::tcp::client send()/recv() call. Closes #100
jbaldwin
force-pushed
the
issue-100/tls_client_hanging
branch
from
29937c5 to
7390870
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSL_read_ex and SSL_write_ex need to be recalled with the same paramters if they return SSL_ERROR_WANT_READ|WRITE. This was left up to the user before.. which is cumbersome and not very intuitive. Now the send() and recv() functions on the net::tls::client are coro:task's so they can properly call SSL_read|write_ex as many times as required. They now also support a timeout since these calls could take longer than a traditional net::tcp::client send()/recv() call.
Closes #100