Add coro::resume_order_policy for coro::event #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifo + fifo
niansa
suggested changes
Jul 26, 2021
|
Yeah I started with it being templated version to remove the branch but then it doesn't compose as well across other usages in the library since it has two concrete types then. I might play around with it as a follow up to see how bad it cascades across everything but for now I'll get this merged so its available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lifo + fifo!
When setting a
coro::eventit is now possible to declare the order in which you want the waiters to be resumed. Default is lifo for performance but fifo can be picked at a runtime perf cost.