Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doctests fail with new Black version. #171

Closed
henrifroese opened this issue Aug 29, 2020 · 2 comments
Closed

Doctests fail with new Black version. #171

henrifroese opened this issue Aug 29, 2020 · 2 comments
Labels
bug Something isn't working testing

Comments

@henrifroese
Copy link
Collaborator

As we could see in #169 and #170 , with the new release of black three days ago, many of our doctests fail. We opened an issue here at Black's Github. Currently, when we want to push something new to Texthero, Travis CI will fail. Current hotfix is to use the last version before the release by setting in .travis.yml: - pip3 install black==19.10b0 and in setup.cfg: black==19.10b0.
@henrifroese henrifroese added bug Something isn't working testing labels Aug 29, 2020
@mk2510 mk2510 mentioned this issue Aug 30, 2020
Open
henrifroese added a commit to SummerOfCode-NoHate/texthero that referenced this issue Sep 4, 2020
@henrifroese
Fix travis version. See Issue jbesomi#171
53632f0
henrifroese added a commit to SummerOfCode-NoHate/texthero that referenced this issue Sep 4, 2020
@henrifroese
Fix black version. See Issue jbesomi#171
0cca7d9
This was referenced Sep 6, 2020
Draft
Open
This was referenced Sep 6, 2020
Open
Merged
@jbesomi jbesomi mentioned this issue Sep 7, 2020
Draft
jbesomi pushed a commit that referenced this issue Sep 8, 2020
@henrifroese @mk2510
Fix type checks to not fail if first value in series is NaN/missing. (#…
55e7a2d 
…174)

* Fix type checks to not fail if first value in series is NaN/missing.

Co-authored-by: Maximilian Krahn <maximilian.krahn@icloud.com>

* Fix black version. See Issue #171

Co-authored-by: Henri Froese <henri.froese@yahoo.com>
Co-authored-by: Maximilian Krahn <maximilian.krahn@icloud.com>
jbesomi pushed a commit that referenced this issue Sep 13, 2020
@henrifroese @mk2510
Add and enforce best practices (#185)
22791b1 
* Fix travis version. See Issue #171

* roll back accidental push to master

* Add & Enforce best practices.

- default argument docstring style
- American English
- default argument values

All those are also added to CONTRIBUTING.md

Co-authored-by: Maximilian Krahn <maximilian.krahn@icloud.com>

Co-authored-by: Henri Froese <henri.froese@yahoo.com>
Co-authored-by: Maximilian Krahn <maximilian.krahn@icloud.com>
@henrifroese henrifroese mentioned this issue Sep 25, 2020
Merged
@jbesomi
Copy link
Owner

jbesomi commented Jul 1, 2021

@henrifroese thanks! Can I close this issue?

@henrifroese
Copy link
Collaborator Author

yes should be good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbesomi @henrifroese