Improved docstring for texthero.nlp.noun_chunks, Closes #62 #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @avinashbhat, thank you for your PR! Unfortunately, as of now, I cannot merge the PR as it does not pass the docstring test. You can read there in CONTRIBUTING.md how you can test the code locally before submit. For any information, does not hesitate to ask. |
|
@jbesomi I apologize! I missed that docstrings have to pass the tests as well. Updated the commit now. |
|
That's perfect! Thank you! 👍 Next step? Open a new PR, edit README.md and add your name under Contributors :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the docstring as discussed here.