improve and document cassandra errors #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- concatenable cassandra errors (+ tests) - errors accept integer error code (not translation) - create error constants so 1) users can compare error codes against constants defined by the module and 2) comparisons are integers instead of strings - error_code_translations: for the error message - document cassandra errors in README
|
Do you disapprove those changes @jbochi ? |
jbochi
added a commit
that referenced
this pull request
Mar 25, 2015
improve and document cassandra errors
|
Sorry for taking so long. I've been very busy this week. These changes make a lot of sense. Thanks for your contribution. |
|
Could you deploy this version @jbochi? That'd be great so we can handle our errors better in Kong! ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jbochi! What do you think about those changes:
cassandra_errorsconstants so 1) users can compare error codes againstconstants defined by the module and 2) comparisons are integers
instead of strings
Also, would you like to setup a Gitter chat for this project to occasionally talk on it?