-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Restructure repository and port every project to project.json #60
Conversation
Drop .NET 4.0, in favor of 4.5.1? I don't know why I added it in the first place. |
4.5.1 is already covered by |
merge, merge, merge 😄 |
@khellang does this need the dotnet/cli tools? |
Nope. All the existing tooling (DNVM/DNX/DNU etc.) |
Should get a AppVeyor/Travis CI build up and running for this. |
AppVeyor for sure, I just got my other projects going there. I hesitated on dropping net451 because I've had reports of issues of ONLY having dotnet5.1, and I assume once netstandard becomes...standard then those issues will go away. |
Alright. I added a net45 target as well. It looks like MS has net45 targets for a lot of their packages in addition to |
Is this one ready to go? When this comes in I'm going to add an actual build script |
Yep, I think so. I have a couple of scripts for Travis (bash) and AppVeyor (PoSH) lying around. They pull down the DNX version specified in global.json for both CLR and CoreCLR, restore, build, test (for both platforms) and pack the projects. I'll create some gists or send a follow-up PR if you're interested 😄 |
@jbogard what's your thoughts on the tests? |
@plioi I'll let you handle this one |
Restructure repository and port every project to project.json
This PR ports all projects to project.json. Every project builds and all the examples runs ✨
The main project targets
net40
anddotnet5.1
. This should cover just about everything and the kitchen sink.All the demo projects target
dnx451
anddnxcore50
, exept the following, because their containers doesn't supportdnxcore50
yet:Currently, the tests doesn't run because Fixie doesn't support running from DNX yet. It's a pretty quick task to port them to xUnit, though.
Let me know what you think 😄
Fixes #59