Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Restructure repository and port every project to project.json #60

Merged
merged 18 commits into from
Dec 30, 2015

Conversation

khellang
Copy link
Contributor

This PR ports all projects to project.json. Every project builds and all the examples runs ✨

The main project targets net40 and dotnet5.1. This should cover just about everything and the kitchen sink.

All the demo projects target dnx451 and dnxcore50, exept the following, because their containers doesn't support dnxcore50 yet:

  • Windsor
  • Unity
  • Ninject

Currently, the tests doesn't run because Fixie doesn't support running from DNX yet. It's a pretty quick task to port them to xUnit, though.

Let me know what you think 😄

Fixes #59

@jbogard
Copy link
Owner

jbogard commented Dec 18, 2015

Drop .NET 4.0, in favor of 4.5.1? I don't know why I added it in the first place.

@khellang
Copy link
Contributor Author

4.5.1 is already covered by dotnet5.1 (see netstandard1.0 which is the same). It's no problem having .NET 4.0 there... But I guess it's no point in supporting it?

@jchannon
Copy link
Contributor

merge, merge, merge 😄

@jchannon
Copy link
Contributor

@khellang does this need the dotnet/cli tools?

@khellang
Copy link
Contributor Author

Nope. All the existing tooling (DNVM/DNX/DNU etc.)

@khellang
Copy link
Contributor Author

Should get a AppVeyor/Travis CI build up and running for this.

@jchannon
Copy link
Contributor

@jbogard
Copy link
Owner

jbogard commented Dec 18, 2015

AppVeyor for sure, I just got my other projects going there. I hesitated on dropping net451 because I've had reports of issues of ONLY having dotnet5.1, and I assume once netstandard becomes...standard then those issues will go away.

@khellang
Copy link
Contributor Author

Alright. I added a net45 target as well. It looks like MS has net45 targets for a lot of their packages in addition to dotnet5.x 👍

@jbogard
Copy link
Owner

jbogard commented Dec 21, 2015

Is this one ready to go? When this comes in I'm going to add an actual build script

@khellang
Copy link
Contributor Author

Yep, I think so. I have a couple of scripts for Travis (bash) and AppVeyor (PoSH) lying around. They pull down the DNX version specified in global.json for both CLR and CoreCLR, restore, build, test (for both platforms) and pack the projects. I'll create some gists or send a follow-up PR if you're interested 😄

@khellang
Copy link
Contributor Author

@jbogard what's your thoughts on the tests?

@jbogard
Copy link
Owner

jbogard commented Dec 22, 2015

@plioi I'll let you handle this one

@plioi
Copy link

plioi commented Dec 22, 2015

@jbogard @khellang The xUnit team has been more adventurous with the moving target of .NET Core. Fixie will get there, but I admit I'm behind on that learning curve. In the interest of letting Mediatr move forward with this PR, I'd recommend a quick port to xUnit, if only for the time being.

jbogard added a commit that referenced this pull request Dec 30, 2015
Restructure repository and port every project to project.json
@jbogard jbogard merged commit a6cd722 into jbogard:master Dec 30, 2015
@khellang khellang deleted the restructure branch December 7, 2016 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants