Migration to asciidoc #73
Conversation
|
Author is not the 'documentation' contributor, members of jbosstm can write comment of text |
Done. Thanks @tomjenkinson |
|
Started testing this pull request: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-documentation/14/ |
|
Thank you @jmfinelli ! |
|
Started testing this pull request: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-documentation/15/ |
|
Started testing this pull request: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-documentation/16/ |
|
Started testing this pull request: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-documentation/17/ |
|
Started testing this pull request: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-documentation/18/ |
| In addition to be able to store appropriate information, all participants within a distributed transaction must log similar information, which allows them to take a same decision either to set data in their final state or in their initial state. | ||
|
|
||
| Two techniques are, in general, used to ensure transaction's atomicity. | ||
| A first technique focuses on manipulated data, such as the Do/Undo/Redo protocol (considered as a recovery mechanism in a centralised system), which allows a participant to set its data in their final values or to retrieve them in their initial values. |
There was a problem hiding this comment.
I am having a look at this PR. This file is strangely long! I can see that it is well migrated, but I can also see duplications in this new file like in the old one. i.e. these lines https://github.com/jbosstm/documentation/pull/73/files#diff-62ade1ca747887147020c9aa09a6bcdf9074ceb197e58ec5cd41cc67eecb1629R278-R333 can be found also at lines https://github.com/jbosstm/documentation/pull/73/files#diff-62ade1ca747887147020c9aa09a6bcdf9074ceb197e58ec5cd41cc67eecb1629R1602-R1656
Some parts look duplicated, do you know why?
There was a problem hiding this comment.
Thanks @marcosgopen. I also noticed that trailmap.adoc has some duplications (and other problems), which are also present in the current documentation. My suggestion is to go ahead with the review and then fix trailmap.adoc once we merge this PR. WDYT?
There was a problem hiding this comment.
I agree, that can be checked in a separate PR since the duplication was already present and it was not introduced in this PR
|
Started testing this pull request: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-documentation/19/ |
|
Started testing this pull request: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-documentation/20/ |
|
Started testing this pull request: https://ci-jenkins-csb-narayana.apps.ocp-c1.prod.psi.redhat.com/job/btny-pulls-documentation/21/ |
|
Great work with the migration @jmfinelli ! LGTM +1 |
This PR addresses JBTM-3921