Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBTM-3269] making commit markable resource working on JDK9+ #270

Merged
merged 3 commits into from
Apr 1, 2020

Conversation

ochaloup
Copy link
Contributor

@ochaloup ochaloup commented Mar 12, 2020

https://issues.redhat.com/browse/JBTM-3269
additional fix which is needed for the introduction of the new CI: https://issues.redhat.com/browse/JBTM-3274

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@ochaloup
Copy link
Contributor Author

@mayankkunwar the Windows tests passed finally (I really battled with profile setup as my Windows installation works differently than the Catelyn).
If you find time, please review or add comments here for me being able to merge this.

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

@jbosstm-bot
Copy link

Copy link
Contributor

@mayankkunwar mayankkunwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At last build passed. Looks good.

@ochaloup ochaloup merged commit a8da81a into jbosstm:master Apr 1, 2020
@@ -28,7 +28,7 @@

<artifactId>lra-test</artifactId>
<packaging>jar</packaging>
<name>Run the example locally</name>
<name>LRA Quickstart lra-test locally</name>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to mention, IMO cleanup is good and should be done - I do think it should be in a separate commit though (same comment for the change below in rts/lra/pom.xml) /cc @ochaloup @mayankkunwar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants