-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JBTM-3269] making commit markable resource working on JDK9+ #270
Conversation
Started testing this pull request: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana-quickstart/208/ |
2fe7117
to
8c50318
Compare
Started testing this pull request: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana-quickstart/209/ |
Started testing this pull request: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana-quickstart/1/ |
8c50318
to
cbe6a90
Compare
Started testing this pull request: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana-quickstart/3/ |
Started testing this pull request: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana-quickstart/7/ |
c161400
to
3cc0c0e
Compare
@mayankkunwar the Windows tests passed finally (I really battled with profile setup as my Windows installation works differently than the Catelyn). |
Started testing this pull request: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana-quickstart/8/ |
3cc0c0e
to
51a0bff
Compare
Started testing this pull request: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana-quickstart/9/ |
…ts build needs to use the newer version of bom
51a0bff
to
a8125a2
Compare
Started testing this pull request: http://narayanaci1.eng.hst.ams2.redhat.com/job/btny-pulls-narayana-quickstart/10/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At last build passed. Looks good.
@@ -28,7 +28,7 @@ | |||
|
|||
<artifactId>lra-test</artifactId> | |||
<packaging>jar</packaging> | |||
<name>Run the example locally</name> | |||
<name>LRA Quickstart lra-test locally</name> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to mention, IMO cleanup is good and should be done - I do think it should be in a separate commit though (same comment for the change below in rts/lra/pom.xml) /cc @ochaloup @mayankkunwar
https://issues.redhat.com/browse/JBTM-3269
additional fix which is needed for the introduction of the new CI: https://issues.redhat.com/browse/JBTM-3274