Skip to content

[JBIDE-26379] moved launcher from base to central #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2018
Merged

[JBIDE-26379] moved launcher from base to central #632

merged 1 commit into from
Sep 24, 2018

Conversation

adietish
Copy link
Member

No description provided.

@adietish
[JBIDE-26379] moved launcher from base to central
982a785 
Signed-off-by: Andre Dietisheim <adietish@redhat.com>
@adietish adietish requested a review from jeffmaury September 24, 2018 13:18
@adietish
Copy link
Member Author

adietish commented Sep 24, 2018 •
edited
Loading

@jeffmaury This is related to jbosstools/jbosstools-central#441
Here we're removing launcher from jbosstools-base, In jbosstools/jbosstools-central#441 we're adding to jbosstools-central.
Please review.

jeffmaury
jeffmaury approved these changes Sep 24, 2018
View reviewed changes
Copy link
Member

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except I don't see the folders being removed but that's maybe a Github issue

@adietish adietish merged commit f1d73e3 into jbosstools:master Sep 24, 2018
@adietish adietish deleted the JBIDE-26379 branch September 24, 2018 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffmaury jeffmaury jeffmaury approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adietish @jeffmaury