[JBIDE-26069] - Spring Boot Project configurator: Creating child module for main project fails #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le for main project fails Signed-off-by: Jeff MAURY <jmaury@redhat.com>
adietish
reviewed
Jun 25, 2018
| MavenProject mavenProject = facade.getMavenProject(monitor); | ||
| ModuleCoreNature.addModuleCoreNatureIfNecessary(facade.getProject(), monitor); | ||
| addUtilityFacet(mavenProject, facade.getProject(), monitor); | ||
| if (ModuleUtils.hasModuleCoreNature(project)) { |
There was a problem hiding this comment.
I'd think that this check isn't required any longer. Or if it is we should most likely error (what else than an error is it if we set the core nature and then the check for it 2 lines further down fails?).
There was a problem hiding this comment.
I was already there and as it was about the root project, I did not want to modify but can remove it if you say so
| public IStatus runInWorkspace(IProgressMonitor monitor) throws CoreException { | ||
| try { | ||
| MavenProject mavenProject = facade.getMavenProject(monitor); | ||
| ModuleCoreNature.addModuleCoreNatureIfNecessary(facade.getProject(), monitor); |
There was a problem hiding this comment.
if we put ModuleCoreNature.addModuleCoreNature into #addUtilityFacet we'd have a single occurrence where module core is added (versus 2 right now). WDYT?
Signed-off-by: Jeff MAURY <jmaury@redhat.com>
adietish
approved these changes
Jun 25, 2018
|
@jeffmaury thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jeff MAURY jmaury@redhat.com