Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't build for UWP #3

Closed
orshir opened this issue Mar 28, 2018 · 2 comments
Closed

Can't build for UWP #3

orshir opened this issue Mar 28, 2018 · 2 comments

Comments

@orshir
Copy link

orshir commented Mar 28, 2018

INPCBinding compilation fails when targeting UWP because IsValueType and BaseType are not supported. There is a way to overcome this using type.GetTypeInfo().BaseType instead of type.BaseType and the same for IsValueType. Should I submit a PR with a fix?
@jbruening
Copy link
Owner

Yes, if you can submit a PR with a fix that would be great.

@ryantrem
Copy link
Collaborator

@jbruening, this issue was resolved by @ritijain in PR #5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbruening @ryantrem @orshir