Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluesky post with url link #15

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Bluesky post with url link #15

merged 2 commits into from
Sep 19, 2023

Conversation

ygrenzinger
Copy link
Contributor

No description provided.

Copy link
Owner

@jbuget jbuget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM (modulo the environment variables in the docker-compose file that seem useless)

@@ -19,6 +19,10 @@ services:
- .env
ports:
- "5432:5432"
environment:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

polish: explicitly declare these variables is not needed because the environment variables are already defined in the .env file.

@@ -4,6 +4,7 @@
"scripts": {
"build": "nuxt build",
"dev": "nuxt dev",
"test": "vitest",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: THANK YOU !!! ❤️

try {
const record: any = {};
record.text = message.text;
record.facets = buildUrlFacets(message.text);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Very pragmatic. Very cool.

@jbuget jbuget merged commit e303282 into jbuget:main Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants