Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#23 PreFormatter annotated with @ToString #27

Merged
merged 1 commit into from
Aug 27, 2014
Merged

Conversation

carlosmiranda
Copy link
Contributor

It appears to work now, please check.

@dmarkov
Copy link

dmarkov commented Aug 19, 2014

Thanks, let me find someone who can review this pull request

@dmarkov
Copy link

dmarkov commented Aug 19, 2014

@yegor256 please review

@carlosmiranda
Copy link
Contributor Author

@yegor256 any update here?

@yegor256
Copy link
Member

yes, I'm not sure it's that easy. I remember that this problem didn't appear in jcabi-log itself, but surfaced when the library was used in some other project. could you please check that this change doesn't break, say, jcabi-github?

@carlosmiranda
Copy link
Contributor Author

Sure, I'll do that. Figured it couldn't have been that simple.

@carlosmiranda
Copy link
Contributor Author

@yegor256 , I tried incorporating it in our other projects but I still couldn't reproduce the bug. Perhaps Lombok has already fixed this in the current version?

@yegor256
Copy link
Member

could be.. ok, thanks

@yegor256
Copy link
Member

@rultor merge pls

@rultor
Copy link
Contributor

rultor commented Aug 27, 2014

@rultor merge pls

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 4a119bc into jcabi:master Aug 27, 2014
@rultor
Copy link
Contributor

rultor commented Aug 27, 2014

@rultor merge pls

@yegor256 Done! FYI, the full log is here (took me 3min)

@dmarkov
Copy link

dmarkov commented Aug 29, 2014

@yegor256 20 mins was added to your account, many thanks for your contribution!

@dmarkov
Copy link

dmarkov commented Aug 29, 2014

@rultor please deploy

@rultor
Copy link
Contributor

rultor commented Aug 29, 2014

@rultor please deploy

@dmarkov OK, I'll try to deploy now. You can check the progress here

@rultor
Copy link
Contributor

rultor commented Aug 29, 2014

@rultor please deploy

@dmarkov Done! FYI, the full log is here (took me 3min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants