Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3 Moved SuppressWarnings from method to local variable scope #4

Merged
1 commit merged into from
May 2, 2014

Conversation

carlosmiranda
Copy link
Contributor

No description provided.

@dmarkov
Copy link

dmarkov commented May 2, 2014

Thanks for the pull request, let me find a reviewer..

@dmarkov
Copy link

dmarkov commented May 2, 2014

@yegor256 could you please review it, keep this in mind: review rules

@dmarkov
Copy link

dmarkov commented May 2, 2014

@yegor256 15 mins is the budget of this code review

@yegor256
Copy link
Member

yegor256 commented May 2, 2014

good to merge

@yegor256 yegor256 assigned ghost May 2, 2014
@ghost
Copy link

ghost commented May 2, 2014

Hey, let me try to merge your branch 3 from carlosmiranda/jcabi-matchers into branch master of jcabi/jcabi-matchers. If there won't be any merge conflicts, I'll try to build it. If it builds without errors, I will merge this pull request. I will let you know in any case, in a few...

@ghost
Copy link

ghost commented May 2, 2014

I've merged your branch 3 into master of jcabi/jcabi-matchers without any merge conflicts. Then, I've built the code and found no problems. Thus, this pull request is accepted and will be merged in a few seconds.

$ Crontab `*/5 * * * *`  allowed execution
  SUCCESS 25ms
$ parallel  allowed with 1 thread(s)
  SUCCESS 1min
$ found 1 pull request(s) in Github
  SUCCESS 5.7s
$ 1 out of 1 request(s) approved
  SUCCESS 12.9s
$ merging request 4
   ?
$ notified GitHub pull request 4 that merging started
  SUCCESS 11.5s
$ EC2 `m1.small` instance `i-3ecc1e6e` created in `us-east-1a`
  SUCCESS 11.8s
$ uploaded `.ssh/config`
  SUCCESS 2min
$ uploaded `.ssh/id_rsa`
  SUCCESS 26.7s
$ chmod 600 ~/.ssh/id\_rsa
  SUCCESS 59ms
$ chmod 600 ~/.ssh/config
  SUCCESS 21ms
$ git clone ssh://git@github.com/carlosmiranda/jcabi-matchers.git code
  SUCCESS 2.2s
$ cd code
  SUCCESS 19ms
$ git remote add dest ssh://git@github.com/jcabi/jcabi-matchers.git
  SUCCESS 112ms
$ git remote update -p
  SUCCESS 349ms
$ git fetch
  SUCCESS 147ms
$ git checkout -b src origin/3
  SUCCESS 44ms
$ git checkout -b dest dest/master
  SUCCESS 67ms
$ git merge src
  SUCCESS 113ms
$ mvn help:system rultor:steps clean install -B -C -Pqulice >&2 1> >(col -b | tee -a ../log.txt) 2> >(col -b | tee -a ../log.txt >&2)
  SUCCESS 4min
$ maven-clean-plugin:clean
  SUCCESS 522ms
$ buildnumber-maven-plugin:create
  SUCCESS 3.3s
$ maven-resources-plugin:resources
  SUCCESS 336ms
$ maven-compiler-plugin:compile
  SUCCESS 11.0s
$ maven-resources-plugin:testResources
  SUCCESS 144ms
$ maven-compiler-plugin:testCompile
  SUCCESS 4.0s
$ maven-surefire-plugin:test
  SUCCESS 8.3s
$ jcabi-maven-plugin:versionalize
  SUCCESS 4.6s
$ maven-jar-plugin:jar
  SUCCESS 2.5s
$ maven-failsafe-plugin:integration-test
  SUCCESS 4.1s
$ qulice-maven-plugin:check
  SUCCESS 2min
$ jslint-maven-plugin:jslint
  SUCCESS 9.4s
$ maven-duplicate-finder-plugin:check
  SUCCESS 3.0s
$ xml-maven-plugin:validate
  SUCCESS 508ms
$ maven-failsafe-plugin:verify
  SUCCESS 8ms
$ maven-install-plugin:install
  SUCCESS 247ms
$ EC2 instance `i-3ecc1e6e` terminated
  SUCCESS 19.0s
$ EC2 `m1.small` instance in `us-east-1a` costed $0.06
  SUCCESS 222ms
$ com.rultor.guard.github.GhRequest#accept()
   ?

ghost pushed a commit that referenced this pull request May 2, 2014
#4: pull request #3 Moved SuppressWarnings from method to local variable scope
@ghost ghost merged commit cdac2f5 into jcabi:master May 2, 2014
@dmarkov
Copy link

dmarkov commented May 2, 2014

@yegor256 Thanks for your contribution, 16 mins was added to your account, payment ID is 000-d0494a7f

@carlosmiranda carlosmiranda deleted the 3 branch May 2, 2014 12:02
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants