XPathContext should be immutable

[carlosmiranda]

The Javadoc for XPathContext helpfully tells us the following: "The class is immutable and thread-safe." This is a blatant lie. :)

1. It's not annotated with @Immutable. And even if it were, it wouldn't work because...
2. The fields map and contexts are instantiated with mutable types.
3. The merge method creates a new instance and manipulates its map field before returning it.

We need to fix that, or change the Javadoc to suit. If we do need to fix it, you may assign it to me - I have a fix ready. :)

[yegor256]

totally agree, we should fix it and annotate with @Immutable, thanks for reporting

[yegor256]

@dmarkov please pay for this report

[dmarkov]

we'll find someone to do this task, soon

[carlosmiranda]

I created a pull request for it at #20 .

[carlosmiranda]

@dmarkov , @yegor256 this report hasn't been paid for yet...

[dmarkov]

@dmarkov please pay for this report

@yegor256 of course. @carlosmiranda many thanks for reporting, I just topped your account up for 15 mins, payment ID: 37432905

[dmarkov]

@carlosmiranda this is your task now, please help. The budget of it is 30 mins

[carlosmiranda]

We're done here, merged pull request at #20.

[dmarkov]

@carlosmiranda Thanks for your contribution, 30 mins was added to your account, payment ID is 37433380