Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XPath "//" doesn't work on cloned nodes #62

Closed
yegor256 opened this issue Mar 20, 2015 · 16 comments
Closed

XPath "//" doesn't work on cloned nodes #62

yegor256 opened this issue Mar 20, 2015 · 16 comments

Comments

@yegor256
Copy link
Member

This test doesn't work:

final XML xml = new XMLDocument("<t6><z9 a='433'/></t6>");
final XML root = xml.nodes("/t6").get(0);
MatcherAssert.assertThat(
  root.xpath("//z9/@a").get(0),
  Matchers.equalTo("433")
);
yegor256 pushed a commit that referenced this issue Mar 20, 2015
@dmarkov
Copy link

dmarkov commented Mar 24, 2015

@yegor256 right, I added the bug tag

@dmarkov dmarkov added the bug label Mar 24, 2015
@dmarkov
Copy link

dmarkov commented Mar 26, 2015

@yegor256 thanks for tis bug, I topped your account for 15 mins, transaction 000-6df0335a

@dmarkov
Copy link

dmarkov commented Jun 5, 2015

@suseika please go ahead, it's your task now, keep this in mind, and don't hesitate to ask any technical questions you may have... The cost of this task is 30 mins (this is exactly how much will be paid, not less not more), when the task is done

@gvlasov
Copy link
Contributor

gvlasov commented Jun 5, 2015

@yegor256 Can you please clarify what exactly is the undesired behavior? In the test you pushed, an h9 node doesn't seem to be appended to a document.

yegor256 pushed a commit that referenced this issue Jun 5, 2015
yegor256 pushed a commit that referenced this issue Jun 5, 2015
@yegor256
Copy link
Member Author

yegor256 commented Jun 5, 2015

@Suseika see this test: 1bc7fc1 It fails, but it shouldn't, as I understand

@yegor256
Copy link
Member Author

yegor256 commented Jun 5, 2015

@Suseika this test works fine if we get rid of cloning. But we need cloning to preserve immutability

@gvlasov
Copy link
Contributor

gvlasov commented Jun 5, 2015

@yegor256 This issue's title speaks about XML#node() method, there is no XML#node() call in 1bc7fc1. I still don't see a way to reproduce the problem I'm assigned to, to me 1bc7fc1 looks like another problem.

@yegor256 yegor256 changed the title node() allows to modify the core document XPath "//" doesn't work on cloned nodes Jun 5, 2015
@yegor256
Copy link
Member Author

yegor256 commented Jun 5, 2015

@Suseika you're right, I updated the description of the ticket and its title

@gvlasov
Copy link
Contributor

gvlasov commented Jun 11, 2015

@yegor256 Will you please check the PR?

@gvlasov
Copy link
Contributor

gvlasov commented Jun 11, 2015

@dmarkov The task is done.

@yegor256 yegor256 reopened this Jun 12, 2015
@yegor256
Copy link
Member Author

@Suseika thanks!

@yegor256
Copy link
Member Author

@rultor release, tag is 0.16.2

@rultor
Copy link
Contributor

rultor commented Jun 12, 2015

@rultor release, tag is 0.16.2

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Contributor

rultor commented Jun 12, 2015

@rultor release, tag is 0.16.2

@yegor256 Done! FYI, the full log is here (took me 10min)

@gvlasov
Copy link
Contributor

gvlasov commented Jun 15, 2015

@dmarkov It's been 3 days, are you going to send a payment?

@dmarkov
Copy link

dmarkov commented Jun 15, 2015

@suseika thanks, paid, 30 mins to your account, payment ID is AP-3VW99570XF804425V, task took 169 hours and 26 mins to complete

+30 to your rating, your total score is +60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants