issue #61 #69
issue #61 #69
Conversation
|
@tmjee I will find a reviewer for your pull requests shortly, thanks for contribution! |
|
@longtimeago could you please review this pull request |
| } .call(); | ||
| }; | ||
| final ExecutorService executorService = Executors.newFixedThreadPool(5); | ||
| for (int count = zero; count < fifty; count = count + 1) { |
There was a problem hiding this comment.
@tmjee It's better to create all Callable instances ant then submit them via ExecutorService#invokeAll()
There was a problem hiding this comment.
@longtimeago if we do
for (...) {
callables.add(
new Callable<..>(){...};
)
}
executor.invokeAll(callables);
we'll get checkstyle warnings AvoidInstantiating objectsInLoops
There was a problem hiding this comment.
@tmjee well ... Agreed ... as our Callable has no state we can reuse it many time
|
@tmjee please, see several remarks above |
|
@longtimeago done. |
| executorService.submit(callable); | ||
| } | ||
| executorService.shutdown(); | ||
| executorService.awaitTermination(tentimes, TimeUnit.SECONDS); |
There was a problem hiding this comment.
@tmjee Hereinafter, awaitTermination returns true if all tasks are finished successfully in given time.
As I said in on of my comments, we should assert that awaitTermination returns true and fail overwise.
MatcherAssert.assertThat(executorService.awaitTermination(tentimes, TimeUnit.SECONDS), Matchers.is(true));
|
@tmjee And one more round, we are very close to finish :) |
|
@longtimeago done. |
| for (int count = zero; count < ten; count = count + 1) { | ||
| executorService.submit(callable); | ||
| } | ||
| executorService.awaitTermination(ten, TimeUnit.SECONDS); |
There was a problem hiding this comment.
@tmjee what about proper shutdown sequence here?
| for (int count = zero; count < fifty; count = count + 1) { | ||
| executorService.submit(runnable); | ||
| } | ||
| executorService.awaitTermination(ten, TimeUnit.SECONDS); |
|
@tmjee please, be more attentive. Several more remarks |
|
@longtimeago done |
|
@tmjee and one more |
|
@tmjee now it's good. Thank you! |
|
@rultor merge |
@longtimeago Thanks for your request. @yegor256 Please confirm this. |
|
@rultor try to merge |
|
@tmjee what happened with the fork? you deleted it? we can't merge |
|
@tmjee not a problem. Please, close this one. |
|
@longtimeago Thanks for your contribution, 22 mins was added to your account, payment ID is |
Fix issue #61 Get rid of AspectJ