Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ABtn): Add button loading state #55

Closed
wants to merge 1 commit into from

Conversation

ManUtopiK
Copy link
Contributor

@ManUtopiK ManUtopiK commented Oct 24, 2022

Just added loading state with svg. Works with all colors and variants :

2022-10-24-12.27.46.014686496.mp4

Tips: for testing, you can change default loading props to true.

I haven't supported button size:

image

@netlify
Copy link

netlify bot commented Oct 24, 2022

Deploy Preview for anu-vue ready!

Name Link
🔨 Latest commit 63b09d0
🔍 Latest deploy log https://app.netlify.com/sites/anu-vue/deploys/63568a312689c60008ba79f8
😎 Deploy Preview https://deploy-preview-55--anu-vue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jd-solanki
Copy link
Owner

For loading, we will need something more than just SVG.

I prefer, creating a new component for a spinner like quasar.

It should have sizing option using em unit to adjust it in components and use it as a separate loader.

Later on, we can use it in buttons and other components.

@ManUtopiK
Copy link
Contributor Author

I'll have time to try building a spinner component next week.
Is this you're looking for ?

@jd-solanki
Copy link
Owner

Is this you're looking for?

If you got some time and willing to contribute feel free to make PR ☺️

if you are building a new component, I suggest reading the contribution guide and discussing the API first so you don't have to modify the PR later.

Thanks.

@jd-solanki
Copy link
Owner

I'm closing this as this will be implemented in Loader PR 😇

@jd-solanki jd-solanki closed this Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants