band_pass_filter - soon to be deprecated

[pravsripad]

DeprecationWarning: Function band_pass_filter is deprecated;
band_pass_filter is deprecated and will be removed in 0.15, use
filter_data instead.

@fboers did you suggest the use of jumeg window sinc filter or the jumeg_mne_filter classes?

@jdammers @ebeich

[fboers]

helau I would use butterwort from jumeg instead of mne beaucse mne is changing some times and some how it is not clear to me if mne has linear phase but may we should write or own FIR windowed-filter function the mne FIR window filter function is a very strong filter (psd plot) #===> make a butter bp1-45 Hz with dc offset correction and notches at 50,100,150,200 Hz from jumeg.filter import jumeg_filter fi_bw_bp = jumeg_filter( filter_method="bw",filter_type=ftype,fcut1=fcut1,fcut2=fcut2,remove_dcoffset=True,sampling_frequency=srate,notch=notch) fi_bw_bp.apply_filter() Am 23.02.2017 um 11:02 schrieb Praveen Sripad: DeprecationWarning: Function band_pass_filter is deprecated; band_pass_filter is deprecated and will be removed in 0.15, use filter_data instead. @fboers<https://github.com/fboers> did you suggest the use of jumeg window sinc filter or the jumeg_mne_filter classes? @jdammers<https://github.com/jdammers> @ebeich<https://github.com/ebeich> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#133>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AGy3qKSeZU9FVm164x9JlryYNZr3-5_bks5rfVlNgaJpZM4MJxCO>.

…

-- Frank Boers Institute of Neuroscience and Medicine - 4 Medical Imaging Physics Forschungszentrum Juelich GmbH 52425 Juelich phone: +49 - (0)2461-61-6005 fax : +49 - (0)2461-61-2820 email: f.boers@fz-juelich.de<mailto:f.boers@fz-juelich.de> http://www.fz-juelich.de/inm/inm-4/DE/Forschung/MEG-Physik/_node.html

------------------------------------------------------------------------------------------------ ------------------------------------------------------------------------------------------------ Forschungszentrum Juelich GmbH 52425 Juelich Sitz der Gesellschaft: Juelich Eingetragen im Handelsregister des Amtsgerichts Dueren Nr. HR B 3498 Vorsitzender des Aufsichtsrats: MinDir Dr. Karl Eugen Huthmacher Geschaeftsfuehrung: Prof. Dr.-Ing. Wolfgang Marquardt (Vorsitzender), Karsten Beneke (stellv. Vorsitzender), Prof. Dr.-Ing. Harald Bolt, Prof. Dr. Sebastian M. Schmidt ------------------------------------------------------------------------------------------------ ------------------------------------------------------------------------------------------------

[pravsripad]

@fboers Okay, so if the Jumeg filter is used, does it not still use mne.filter.band_pass_filter from mne? Will that have to be changed as well?

As in, the JuMEG_Filter_MNE class.

[fboers]

Hi again, no you can choose bw/ws/mne(FIR) the <bw> will be the best at this time ws is obsolete see you next week Frank Am 23.02.2017 um 11:41 schrieb Praveen Sripad: @fboers<https://github.com/fboers> Okay, so if the Jumeg filter is used, does it not still use mne.filter.band_pass_filter from mne? Will that have to be changed as well? As in, the JuMEG_Filter_MNE class. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#133 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AGy3qFNJ0UbIbzzZBWIB9dfiRY6nUiA6ks5rfWJlgaJpZM4MJxCO>.

…

-- Frank Boers Institute of Neuroscience and Medicine - 4 Medical Imaging Physics Forschungszentrum Juelich GmbH 52425 Juelich phone: +49 - (0)2461-61-6005 fax : +49 - (0)2461-61-2820 email: f.boers@fz-juelich.de<mailto:f.boers@fz-juelich.de> http://www.fz-juelich.de/inm/inm-4/DE/Forschung/MEG-Physik/_node.html

------------------------------------------------------------------------------------------------ ------------------------------------------------------------------------------------------------ Forschungszentrum Juelich GmbH 52425 Juelich Sitz der Gesellschaft: Juelich Eingetragen im Handelsregister des Amtsgerichts Dueren Nr. HR B 3498 Vorsitzender des Aufsichtsrats: MinDir Dr. Karl Eugen Huthmacher Geschaeftsfuehrung: Prof. Dr.-Ing. Wolfgang Marquardt (Vorsitzender), Karsten Beneke (stellv. Vorsitzender), Prof. Dr.-Ing. Harald Bolt, Prof. Dr. Sebastian M. Schmidt ------------------------------------------------------------------------------------------------ ------------------------------------------------------------------------------------------------

[pravsripad]

Closed with #147.