Fix issue where active button style pushes content down 1px #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when a button was pressed, the content below it would shift down 1px. This bug was introduced in #44 which added the effect of the text shifting left and down 1px on press. After this commit, the text of the button still shifts down and left 1px but the overall height of the button does not change. This commit introduces a small issue where the button does not shift down visually in Safari. Fix #145
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jdan
reviewed
Oct 24, 2022
Make the padding change on an :active button properly shift the text right 1px regardless of if the button contains only a little text (keeping the button at its `min-width`) or if the button contains a lot of text.
|
#150 introduced a cool hack with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when a button was pressed, the content below it would shift down 1px. This bug was introduced in #44 which added the effect of the text shifting left and down 1px on press.
After this commit, the text of the button still correctly shifts down and left 1px but the overall height of the button does not change.
This commit introduces a small issue where the button does not shift down visually in Safari.
Fix #145