-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move text on button press #44
Conversation
build/98.css
Outdated
@@ -102,6 +102,7 @@ button:not(:disabled):active { | |||
box-shadow: inset -1px -1px #ffffff, | |||
inset 1px 1px #0a0a0a, inset -2px -2px #dfdfdf, | |||
inset 2px 2px #808080; | |||
padding: 2px 11px 0 13px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the exact same fix. Just to note for posterity on some of the idiosyncrasies of the fix:
2px
was required due to Chrome not moving a1px
value. There appears to be a conflicting rule in css resolution there0px
for the bottom as negative values aren't valid in FireFox and Chrome forpadding
. Interestingly, fullpadding-top
,right
, etc. does actually work with a negative value. Issue is specifically with the condensedpadding
tag and negative values for both browsers.
Is there a way to do this without padding? I worry about someone adding their own padding (for larger buttons) and forgetting to add/subtract one on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Padding Q
Perhaps you can make use of an invisible border instead since |
I had a go at implementing your suggestion on #79 :) |
@fstr0 I'm happy to merge this as-is, since I don't think we can do better than adjusting the padding :) Wanna rebase off master? |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/jdan/98css/1m4i1tq0b |
@jdan I think that is done now? I'm a GitHub noob so let me know if I did it wrong |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @fstr0,
Sorry for the pain! We've removed build/98.css
and docs/98.css
from version control, so they'll need to be git rm
d before I merge.
@fstr0 thanks so much <3 |
Modify padding on active button to move the text 1px down and 1px right to replicate behaviour in Win98.
This fixes issue #34.