Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TableView component #151

Merged
merged 5 commits into from
Nov 13, 2022

Conversation

robert-ryu7
Copy link
Collaborator

Hi,

Here is a piece of code that I've written with the intention to use it in one of my side projects. Not sure if it's good enough to be merged but maybe it will be of use to someone.

I expect this might need some further testing and tweaking especially since I currently don't have access to better reference material.

@vercel
Copy link

vercel bot commented Nov 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
98css ✅ Ready (Inspect) Visit Preview Nov 13, 2022 at 8:02PM (UTC)

@jdan
Copy link
Owner

jdan commented Nov 13, 2022

It's a neat idea! Would it be possible to remove the class names and apply these styles to semantics like table and tbody? (I like to minimize the need for class names as much as possible)

Regardless I'll give you commit access since this PR is great, you're welcome to merge / tend to the garden / do anything else you'd like!

@robert-ryu7
Copy link
Collaborator Author

Hey @jdan, thanks for the invite. :)

I'll remove redundant class from table and merge when ready.

@robert-ryu7
Copy link
Collaborator Author

@jdan Could you take another look before I merge this? I've made some optimizations to sunken panel and would appreciate your opinion.

Border rendering is now done differently than other similiar components but this allows me to use only one wrapper element to properly handle overflow. Is that ok or should I revert to using box-shadow?

@jdan
Copy link
Owner

jdan commented Nov 13, 2022

@robert-ryu7 I have a preference for box-shadow over border-image for purity's sake but you're welcome to merge this as you see fit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants