Sunny/bicep deployer #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cyclam
reviewed
May 6, 2023
|
If the intention is for this command group to also include generating network service designs (as the README says), then I don't think |
Suggestion from cyclam Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com>
jddarby
pushed a commit
that referenced
this pull request
Oct 19, 2023
…count container copy, api-version 2023-09-15-preview (Azure#6703) * init changes for 20230915-preview api * Changes to add enablePriorityBasedExecution and defaultPriorityLevel * Removed isPreview flag from CMK related properties and added key-uri to cosmosdb update operation. * Added test and test recording for priority based execution * corrected resource group name and whitespace corrections * white space corrections * Add cosmosdb copy command * Add tests * Dts/cross account copy (#3) * Deprecate old command * Add test recording for dts --------- Co-authored-by: Nitesh Vijay <niteshvijay@microsoft.com> * Fix build error * Fix Static Analysis * Use boolean type * Change help text * Update help text * Updated Vendored SDK * Updated test account name in test_cosmosdb-merge-scenario.py * Whitespace correction and added linter exclution for enable pbe * Updated linter_exclusions * Remove id part * Corrected account name in test_cosmosdb-merge-scenario.py and generated test recordings * Generated test recording for test_cosmosdb_materializedview * Add support for MI Cassandra in 2023-09-15 * Add -n for jobname * Fix breaking change * Modified setup.py and history.rst * Fix static check * Whitespace correction * Re-recorded tests * rerecorded test test_cosmosdb_sql_materializedview_scenario * removed linter exclusion for enable_priority_based_execution * Rerecorded all tests * Updated HISTORY.rst * Rerecorded tests * rerecorded test_cosmosdb_sql_materializedview_scenario * rerecorded test_cosmosdb_sql_materializedview_scenario * rerecorded tests --------- Co-authored-by: Achint Agrawal <acagrawal@microsoft.com> Co-authored-by: AdrianSibajaRetana <54075415+AdrianSibajaRetana@users.noreply.github.com> Co-authored-by: Nitesh Vijay <niteshvijay@microsoft.com> Co-authored-by: Nitesh Vijay <niteshvijay1995@gmail.com> Co-authored-by: Guanzhou <guanzhousong@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.