Fix handling of attached retroflex in pinyinize #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CC-CEDICT syntax wiki describes the retroflex finals as:
However, in pycedict, cases 2 and 3 are not properly handled by
pinyinize
. The problem is two fold:r5
it fails atvowels = list(vowels)
.This problem was raised as issue #2.
This PR aims at fixing both problems by:
vowels = list(vowels)
after the already existing special handling ofr5
.A diff between the results with and without the fix did not show any breaking cases.