-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate language from path in hash #108
Comments
That's a valid point you are making. However there are also some different approaches that might work here. What solution should we take?
|
I think I like option 1 here. |
I think I would also not append the language query parameter until the language is explicitly changed from the dropdown, too. |
aleksandrs-ledovskis
added a commit
to aleksandrs-ledovskis/asknot
that referenced
this issue
Jan 19, 2014
Closes jdmgh-108 Signed-off-by: Aleksandrs Ļedovskis <aleksandrs@ledovskis.lv>
aleksandrs-ledovskis
added a commit
to aleksandrs-ledovskis/asknot
that referenced
this issue
Jan 19, 2014
Closes jdmgh-108 Signed-off-by: Aleksandrs Ļedovskis <aleksandrs@ledovskis.lv>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the hash contains both the language and the current path. That's not great for the default linking experience, since the language will override the user's preferred default. We should make the override language a query parameter instead (?zh-TW=1).
The text was updated successfully, but these errors were encountered: