Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate language from path in hash #108

Closed
jdm opened this issue Dec 5, 2013 · 3 comments · Fixed by #130
Closed

Separate language from path in hash #108

jdm opened this issue Dec 5, 2013 · 3 comments · Fixed by #130

Comments

@jdm
Copy link
Owner

jdm commented Dec 5, 2013

Currently the hash contains both the language and the current path. That's not great for the default linking experience, since the language will override the user's preferred default. We should make the override language a query parameter instead (?zh-TW=1).

@aleksandrs-ledovskis
Copy link
Contributor

That's a valid point you are making.

However there are also some different approaches that might work here. What solution should we take?

  1. Remove locale prefix from location hash and convert it to query parameter.
    http://whatcanidoformozilla.org/#!/en/proglang/rust becomes
    http://whatcanidoformozilla.org/?l=en#!/proglang/rust. Please correct me, if I had misunderstood your proposal.
  2. Make first parameter of location hash optional.
    http://whatcanidoformozilla.org/#!/proglang/rust becomes
    http://whatcanidoformozilla.org/#!/en/proglang/rust after initial page load for en locale browser.
  3. Add two permalink-links on page. One would be for "generic" permalink (w/o locale string), other for "localized" (w/ currently visible locale).

@jdm
Copy link
Owner Author

jdm commented Jan 8, 2014

I think I like option 1 here.

@jdm
Copy link
Owner Author

jdm commented Jan 8, 2014

I think I would also not append the language query parameter until the language is explicitly changed from the dropdown, too.

aleksandrs-ledovskis added a commit to aleksandrs-ledovskis/asknot that referenced this issue Jan 19, 2014
Closes jdmgh-108

Signed-off-by: Aleksandrs Ļedovskis <aleksandrs@ledovskis.lv>
aleksandrs-ledovskis added a commit to aleksandrs-ledovskis/asknot that referenced this issue Jan 19, 2014
Closes jdmgh-108

Signed-off-by: Aleksandrs Ļedovskis <aleksandrs@ledovskis.lv>
@jdm jdm closed this as completed in #130 Jan 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants