Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding & as & [Minor] #78

Closed
sudheesh001 opened this issue Jun 26, 2013 · 1 comment
Closed

Encoding & as & [Minor] #78

sudheesh001 opened this issue Jun 26, 2013 · 1 comment

Comments

@sudheesh001
Copy link
Contributor

File: index.html

Line: 171
<li target="https://wiki.mozilla.org/Auto-tools/New_Contributor">Tools & Automation
          <div class="extra" data-l10n-id="py-tools-extra"></div>
</li>

Validator

& did not start a character reference. 
(& probably should have been escaped as &amp;.)

Though a very minor problem and compatible on major web browsers, it becomes important in the case of browsers (which we shouldn't ignore being good web devs) which would break the parsing. Lenient browsers like Firefox, Chrome, Safari don't have a problem, but we should always consider the fact that there shouldn't be a problem in the webpage design and layout. So a small fix would be.

<li target="https://wiki.mozilla.org/Auto-tools/New_Contributor">Tools &amp; Automation
          <div class="extra" data-l10n-id="py-tools-extra"></div>
</li>

Though HTML5 allows you to leave it unescaped, but only when the data that follows does not look like a valid character reference. However, it's better just to escape all instances of this symbol than worry about which ones should be and which ones don't need to be.

jdm added a commit that referenced this issue Jun 27, 2013
Fixing the issue of encoding & as &amp; #78 [FIX]
@DronRathore
Copy link
Contributor

@jdm We can close this issue as you have already merged it, stacking up in Open Issues list. 🚌

@jdm jdm closed this as completed Jul 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants