Defs parser is sensitive to declaration order

[ngConsulti]

It would seem that definitions are processed depth-first, rather then breadth-first. As the code is today, dependencies must be defined before their dependents.

This schema works...

{
    "type":"object",
    "title":"Itinerary",
    "$schema": "http://json-schema.org/draft-04/schema#",
    "definitions": {
        "Leg": {
            "type":"object",
            "properties": {
                "Carrier": {
                    "type":"string"
                }
            }
        },
        "Segment": {
            "type":"object",
            "properties":{
                "Legs": {
                    "type":"array",
                    "items":{
                        "$ref":"#/definitions/Leg"
                    }
                }
            }
        },
        "Trip": {
            "type":"object",
            "properties": {
                "Segments": {
                    "type":"array",
                    "items":{
                        "$ref":"#/definitions/Segment"
                    }
                }
            }
        }
    },
    "properties": {
        "Trips": {
            "type":"array",
            "items": {
                "$ref":"#/definitions/Trip"
            }
        }
    }
}

...while this one doesn't. It fails with:
Uncaught Must set ajax option to true to load external url #/definitions/Segment

{
    "type":"object",
    "title":"Itinerary",
    "$schema": "http://json-schema.org/draft-04/schema#",
    "definitions": {
        "Trip": {
            "type":"object",
            "properties": {
                "Segments": {
                    "type":"array",
                    "items":{
                        "$ref":"#/definitions/Segment"
                    }
                }
            }
        },
        "Segment": {
            "type":"object",
            "properties":{
                "Legs": {
                    "type":"array",
                    "items":{
                        "$ref":"#/definitions/Leg"
                    }
                }
            }
        },
        "Leg": {
            "type":"object",
            "properties": {
                "Carrier": {
                    "type":"string"
                }
            }
        }
    },
    "properties": {
        "Trips": {
            "type":"array",
            "items": {
                "$ref":"#/definitions/Trip"
            }
        }
    }
}

[jdorn]

Good catch. I didn't think of that use case. I'll have to do some research on better dependency resolution algorithms. Currently, I just use a simple loop.

[ngConsulti]

Of course, defining things in reverse dependency order is a valid
workaround. Thanks for this awesome tool...if I find some time I'll
contribute back...

Nathan Probst
ngConsulti http://ngConsulti.com
970.402.7384

On Wed, Mar 12, 2014 at 3:37 PM, Jeremy Dorn notifications@github.comwrote:

Good catch. I didn't think of that use case. I'll have to do some research
on better dependency resolution algorithms. Currently, I just use a simple
loop.

Reply to this email directly or view it on GitHubhttps://github.com//issues/71#issuecomment-37470763
.

[varuag]

While at it, it'd be great if it also handled recursive schemas.
Recursive schemas run into the same problem as above, but the workaround of defining things in reverse does not work.