Add empty option for non-required dynamic select boxes #506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change seems to have a bug. If the empty option is selected, the field should not appear in the resulting JSON value. Right now, the field still shows up, but as an empty string. |
kshepard
force-pushed
the
feature/empty-option-dynamic
branch
from
3a58d24 to
8ca8ae9
Compare
|
@jdorn: good call, thanks. It was using an empty string as the value when it should have been using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #461 added empty options to non-required select boxes, but it didn't do so for dynamic select boxes (those with watched fields). This commit adds that capability.