on Windows, diskCacheRoot doesn't start with /

[ghazel]

Pretty obvious, Windows paths don't start with /

[jech]

Pretty obvious, Windows paths don't start with /

You can merge this Pull Request by running:

git pull https://github.com/ghazel/polipo win_path

Hmm, I'm afraid that this introduces a security hole. You should check
for the disk entry being of the form

X:/XXX

-- Juliusz

[ghazel]

Hm, would just returning if PathIsRelative(diskCacheRoot->string[0]) cover it?

[jech]

The opposite, but yes, I think so.

Reference:

http://msdn.microsoft.com/en-us/library/windows/desktop/bb773660(v=vs.85).aspx

[ghazel]

Opposite? The functions seem to return if diskCacheRoot->string[0] != '/' meaning "root is not absolute", right? So the Windows equivalent would be:

     if(diskCacheRoot == NULL ||
        diskCacheRoot->length <= 0 || PathIsRelative(diskCacheRoot->string[0]))

[jech]

My bad. Greg, could you please fix that? It is a potential security hole.

--jch

[jech]

Fixed by 2005534.