added option to append any string (arguments) to the ssh command

[ksere]

No description provided.

[jedrichards]

Hey thanks! Can we have a test for this? See this test for an example of how we test ssh stuff https://github.com/jedrichards/rsyncwrapper/blob/master/tests/remote-src.js

Also could you expand a bit in the readme? Maybe a short sentence or example about when/why this option is useful? What sort of arguments often need to be appended?

[ksere]

Hi,

It just appends anything in sshCmdArgs to rshCmd after the -p and -i options.

I used this to fix issues with Windows ports of ssh, which couldn't find things like the knownhosts file, so using something like
sshCmdArgs: '-oUserKnownHostsFile=/myhome/.ssh/known_hosts', solves the problem. In the same way you can add any option the ssh-client supports.

I will try to figure out "Vows Async BDD" and write a relevant test.

[jedrichards]

Cool, sounds handy. You can probably just copy and paste that test file to create your own. The basic idea is that you set noExec to true which stops the actual rsync invocation from happening, and then you test that the command string rsyncwrapper generated is what you expect it to be.

[jedrichards]

I'm going to merge this now without tests because it looks like it'll help with #37, and add a few tests myself in the next few days then make a new release. Thanks! :)

[ksere]

Hi, sorry i got caught up with other stuff and never got around to write
those tests myself. Thanks!

On 7 January 2016 at 12:10, Jed Richards notifications@github.com wrote:

I'm going to merge this now without tests because it looks like it'll help
with #37 #37, and add a
few tests myself in the next few days then make a new release. Thanks! :)

—
Reply to this email directly or view it on GitHub
#38 (comment)
.