Skip to content

Implemented Cypher.expand to flatten CypherProps into properties for MATCH statements #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 30, 2016
Merged

Implemented Cypher.expand to flatten CypherProps into properties for MATCH statements #19

merged 3 commits into from
Mar 30, 2016

Conversation

jeffmay
Copy link
Owner

@jeffmay jeffmay commented Mar 21, 2016

@mingy711 @macmacbr @audax-shreyaspurohit

This feature required some refactoring:

  • I took the opportunity to split up the giant test file into separate test suites so that it was easier to run just the suite that I was working on.
  • Switched AsyncWordSpec to AsyncFreeSpec because of stupid test output bugs related to asynchronous test runner output losing group information
  • I refactored some of the exceptions which were not fully finished from a previous PR
  • Moved some validation from CypherStringContext to CypherStatement. Now CypherStatement.validate() will check that all references in a Cypher template have matching parameters.
  • Added other validation in CypherStringContext and tests

Jeff May added 2 commits March 17, 2016 15:48
Cleanup deprecated method usage.
cc3de07
Updated tests.
89f8c2d 
- Added WSDefaultShows
- Split basic specs into separate test classes
- Added CreateNodeWithPropsObject query
- Added InvalidCypherQueriesSpec to test expected failures
@coveralls
Copy link

Coverage Status

Coverage increased (+5.3%) to 73.355% when pulling cc996f8 on expand-param into d3e7ca1 on master.

Implemented Cypher.expand and simplified role of CypherStringContext
bc81ccd 
- Added CypherStatementFragment
- Added CypherStatement.validate()
- Added Cypher.expand()
- Updated tests
- Unified exceptions
- Deprecated old exceptions
@coveralls
Copy link

Coverage Status

Coverage increased (+5.2%) to 73.197% when pulling bc81ccd on expand-param into d3e7ca1 on master.

@jeffmay
Copy link
Owner Author

jeffmay commented Mar 24, 2016

@mingy711 @macmacbr @audax-shreyaspurohit Bump. I'm going to merge this next week, just heads up.

@audax-shreyaspurohit
Copy link
Collaborator

ok

@jeffmay jeffmay merged commit b8cad85 into master Mar 30, 2016
@jeffmay jeffmay deleted the expand-param branch March 30, 2016 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffmay @coveralls @audax-shreyaspurohit