Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processes site when writing file #629

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

coreycarvalho
Copy link
Collaborator

@coreycarvalho coreycarvalho commented May 1, 2021

This PR seeks to address #623.

Resolved #623

Instead of reading the entire site, which could lead to duplicating files, I opted to just re-process the site.

@coreycarvalho
Copy link
Collaborator Author

coreycarvalho commented May 2, 2021

Two tests break with Jekyll 4.2. Going to work on that and commit over the coming days.

Edit: Discovered the change that broke the test: https://github.com/jekyll/jekyll/pull/8497/files

@Martfed
Copy link

Martfed commented May 20, 2021

hi @coreycarvalho any news on this? If you need help I would be happy to do so

@coreycarvalho
Copy link
Collaborator Author

Hey @Martfed - I opened up #631 to fix the failing tests. My plan was to rebase this PR onto the 631 once it gets approved and merged.

@Martfed
Copy link

Martfed commented May 20, 2021

Awesome, thank you!

@coreycarvalho
Copy link
Collaborator Author

@Martfed I amended my commit message to force the test suite to run again... it looks like jekyll-4.2.1 fixed the issue with the tests. If this passes, I'd love to get this merged in.

Copy link
Member

@ashmaroli ashmaroli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ashmaroli
Copy link
Member

Thanks @coreycarvalho

@ashmaroli ashmaroli merged commit 43e8839 into jekyll:master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin pages duplicated
3 participants