Excludes should be relative to the site source

[parkr]

Fixes #1915.

Should we do the same for include entries?

[parkr]

Thoughts on removing glob_include? from core extensions and moving it to EntryFilter, @mattr-?

[mattr-]

Seems fine to move it to EntryFilter.

I'm also thinking that we should do the same thing for include entries as well (make them relative to the site source).

[mattr-]

Did you want to add include support before this gets merged?

[parkr]

@mattr- No, we'll take care of includes in another PR.

[parkr]

/cc @benbalter

[benbalter]

May want to update the docs with the new behavior?

[mattr-]

Yes! Good call!

[mattr-]

Updated the docs in f3e9eb9

Here's what the new section in the config documentation looks like:

[parkr]

Thanks! ❤️

[jbranchaud]

Just to make sure I am clear on how this works. Let's say I have a jekyll project with css/, assets/css/ and the rest of the standard jekyll stuff and my _config.yml has an exclude like the following:

exclude: ['css']

In the current version of jekyll, this exclude would exclude both css/ and assets/css/, despite only intending to exclude the former. Does the new behavior addressed by this issue mean that only the first will be excluded in my scenario? Also, does one need to use something like ./ to notate a relative directory path or is this implicit?

[parkr]

Want to add a test for your use case in a new PR? :)

[jbranchaud]

I could probably do that, but I wanted to make sure I understood the intent of this issue/PR. What did you have in mind when you were proposing and adding this behavior?

[parkr]

We wanted to be able to do this: https://github.com/jekyll/jekyll/pull/1916/files#diff-d75d4058553eb8ed1fb5585b22754decR102

[jbranchaud]

@parkr I have added some test cases in #2046.