New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site template header links to pages which have a title #2411

Merged
merged 1 commit into from May 15, 2014

Conversation

Projects
None yet
3 participants
@mathbruyen
Contributor

mathbruyen commented May 15, 2014

Header used to add link to all pages of the site, even those which do not have any title, creating empty anchors on the page like <a class="page-link" href="/feed.xml"></a>. Those were non click-able and used space on the page due to margins.

Now only displays pages with a title.

Should there be a test for that? I'm not sure about the code style, should there be newlines around the anchor?

Header links to pages which have a title
Header used to add link to all pages of the site, even those which do not have any title, creating empty anchors on the page like `<a class="page-link" href="/feed.xml"></a>`. Those were non click-able and used space on the page due to margins.

Now only displays pages with a title.
@parkr

This comment has been minimized.

Member

parkr commented May 15, 2014

This reads fine for me. Thank you!

parkr added a commit that referenced this pull request May 15, 2014

@parkr parkr merged commit 996bf25 into jekyll:master May 15, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request May 15, 2014

@mathbruyen mathbruyen deleted the mathbruyen:patch-1 branch May 16, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.