Remove conditional assignment from Document URL #2575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -127,7 +127,7 @@ def permalink | |||
| # | |||
| # Returns the computed URL for the document. | |||
| def url | |||
| @url ||= URL.new({ | |||
| @url = URL.new({ | |||
There was a problem hiding this comment.
Does the permalink method not take from data?
There was a problem hiding this comment.
@parkr It does, but when url is first called at the beginning of read, data is not yet initialized, so the URL ends up not taking into consideration the permalink at all.
|
Can you please include this PR in v. 2.1.1? I would really like to be able to set custom permalinks for documents inside collection, as I can not get the navigation to work the right way otherwise (see #2560 ). |
parkr
added a commit
that referenced
this pull request
Jul 10, 2014
parkr
added a commit
that referenced
this pull request
Jul 10, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conditional assignment was making results from
urlquite outdated, causing #2557.This PR provides a fix for the issue as well as a test covering document permalinks.