Remove unnecessary Jekyll::Tags::IncludeTag#blank? method #2625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! We'll just wait to make sure the travis build gives us 💚 |
|
GRÜN |
parkr
added a commit
that referenced
this pull request
Jul 22, 2014
|
Thanks for the pull request, Flo! |
|
I’m really happy @fw42 helps here. Thank you very much. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced in 421e58a to fix a break of backwards compatibility in Liquid 2.5 (Shopify/liquid#218). The commit that introduced that bug was reverted (the 2.5 and 2.6 branches don't contain any blank tag optimization), so this is not an issue anymore.
Also, the "bug" was fixed on master (upcoming Liquid 3.0) in Shopify/liquid@2efe809, so this shouldn't be necessary anymore.
@parkr, please take quick look.
cc @zerobase