Remove unnecessary Jekyll::Tags::IncludeTag#blank? method #2625

Merged
merged 1 commit into from Jul 22, 2014

Conversation

Projects
None yet
4 participants
@fw42
Contributor

fw42 commented Jul 22, 2014

This was introduced in 421e58a to fix a break of backwards compatibility in Liquid 2.5 (Shopify/liquid#218). The commit that introduced that bug was reverted (the 2.5 and 2.6 branches don't contain any blank tag optimization), so this is not an issue anymore.

Also, the "bug" was fixed on master (upcoming Liquid 3.0) in Shopify/liquid@2efe809, so this shouldn't be necessary anymore.

@parkr, please take quick look.
cc @zerobase

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 22, 2014

Member

LGTM! We'll just wait to make sure the travis build gives us 💚

Member

parkr commented Jul 22, 2014

LGTM! We'll just wait to make sure the travis build gives us 💚

@fw42 fw42 referenced this pull request in Shopify/liquid Jul 22, 2014

Merged

Remove unnecessary blank? code #389

@parkr parkr merged commit a776fda into jekyll:master Jul 22, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 22, 2014

Member

GRÜN

Member

parkr commented Jul 22, 2014

GRÜN

parkr added a commit that referenced this pull request Jul 22, 2014

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 22, 2014

Member

Thanks for the pull request, Flo!

Member

parkr commented Jul 22, 2014

Thanks for the pull request, Flo!

@penibelst

This comment has been minimized.

Show comment
Hide comment
@penibelst

penibelst Jul 24, 2014

Member

I’m really happy @fw42 helps here. Thank you very much.

Member

penibelst commented Jul 24, 2014

I’m really happy @fw42 helps here. Thank you very much.

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.