add abort button to retry save modal and several other fixes for it #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Croodle shows a modal if saving a participation fails. The modal allows a user to retry the save attempt. While it was always possible to close the button by clicking on backdrop or using escape key, a button to do so was missing. A user may not know about the user ways and may see reloading the page as only possibilty to close the modal if he doesn't want to retry again. This adds the missing abort button and fixes some smaller bugs including: - The modal was missing a title. - If the modal was closed once it wasn't reopened on another failed saving attemp unless the user has visit another page in between. - Several arguments were passed to <BsModal> that weren't existing at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Croodle shows a modal if saving a participation fails. The modal allows a user to retry the save attempt. While it was always possible to close the button by clicking on backdrop or using escape key, a button to do so was missing. A user may not know about the user ways and may see reloading
the page as only possibilty to close the modal if he doesn't want to retry again.
This adds the missing abort button and fixes some smaller bugs including:
<BsModal>that weren't existing at all.