Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add abort button to retry save modal and several other fixes for it #291

Merged
merged 1 commit into from
Nov 10, 2019

Commits on Nov 9, 2019

  1. add abort button to retry save modal and several other fixes for it

    Croodle shows a modal if saving a participation fails. The modal allows
    a user to retry the save attempt. While it was always possible to close
    the button by clicking on backdrop or using escape key, a button to do so
    was missing. A user may not know about the user ways and may see reloading
    the page as only possibilty to close the modal if he doesn't want to retry
    again.
    
    This adds the missing abort button and fixes some smaller bugs including:
    
    - The modal was missing a title.
    - If the modal was closed once it wasn't reopened on another failed saving
      attemp unless the user has visit another page in between.
    - Several arguments were passed to <BsModal> that weren't existing at all.
    jelhan committed Nov 9, 2019
    Configuration menu
    Copy the full SHA
    d312172 View commit details
    Browse the repository at this point in the history