Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Feedback: 👎
I created this PR to address this rule:
"There should be no hard-coded values or magic numbers in the code."
Description
This PR addresses the issue of hard-coded values in the
fileTypesOptions
array in thesrc/lib.ts
file. Instead of hard-coding the values, we now fetch them dynamically from a new configuration file,src/fileTypesConfig.json
.Changes made:
src/fileTypesConfig.json
that stores the file types and their corresponding labels.src/lib.ts
file to replace the hard-codedfileTypesOptions
array with a function that reads thefileTypesConfig.json
file and returns the file types and labels dynamically.Summary of Changes
src/fileTypesConfig.json
.src/lib.ts
:fs
module to read thefileTypesConfig.json
file.fileTypesOptions
array with a function that fetches the file types and labels fromfileTypesConfig.json
.This change ensures that we adhere to the best practice of not having hard-coded values in our code.