Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental native audio player #339

Merged
merged 15 commits into from
Apr 6, 2022

Conversation

thornbill
Copy link
Member

@thornbill thornbill commented Feb 3, 2022

Remaining issues:

  • Seeking is broken
    • Seeking will require managing the queue on the native side of things so I think I will leave that for a separate PR. Fixed.
  • Play icon is wrong when next song in queue plays
  • Fix "script error" at end of queue
  • Fix "script error" when next song in queue plays
  • Play icon does not update when paused
  • Playback does not stop when webview is refreshed
  • Does not automatically play next song in queue
  • SonarQube code smell
  • Failing tests

@thornbill thornbill added the enhancement New feature or request label Feb 3, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
1.5% 1.5% Duplication

@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #339 (9826f8b) into master (4986e0b) will decrease coverage by 1.12%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
- Coverage   48.75%   47.63%   -1.13%     
==========================================
  Files          40       41       +1     
  Lines         722      781      +59     
  Branches      143      162      +19     
==========================================
+ Hits          352      372      +20     
- Misses        333      365      +32     
- Partials       37       44       +7     
Impacted Files Coverage Δ
components/NativeShellWebView.js 16.66% <0.00%> (-1.25%) ⬇️
components/VideoPlayer.js 25.39% <ø> (ø)
screens/HomeScreen.js 0.00% <0.00%> (ø)
screens/DevSettingsScreen.js 62.50% <25.00%> (-37.50%) ⬇️
components/AudioPlayer.js 34.14% <34.14%> (ø)
stores/MediaStore.js 100.00% <100.00%> (ø)
stores/SettingStore.js 100.00% <100.00%> (ø)
utils/StaticScriptLoader.js 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@thornbill thornbill force-pushed the native-audio branch 2 times, most recently from 280d454 to 9dd0831 Compare March 26, 2022 03:09
@thornbill thornbill marked this pull request as ready for review March 28, 2022 04:52
@sonarcloud
Copy link

sonarcloud bot commented Mar 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thornbill thornbill merged commit cf20a46 into jellyfin:master Apr 6, 2022
@thornbill thornbill deleted the native-audio branch April 6, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

2 participants