Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show next episode popup if web client setting is turned on #1101

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

cewert
Copy link
Member

@cewert cewert commented Mar 19, 2023

Changes

  • check web client setting before showing next episode popup
  • save m.user.configuration to a global var for easy access from components - m.global.userConfig
    • remove userConfig field from XML nodes that were using it

Issues

Fixes #1099

@cewert cewert marked this pull request as ready for review March 19, 2023 16:54
@cewert cewert requested a review from jimdogx March 19, 2023 16:54
components/JFVideo.brs Outdated Show resolved Hide resolved
@cewert
Copy link
Member Author

cewert commented Mar 22, 2023

Instead of pushing the userConfig down to each component that needs it, I've saved it to a global var where it can be accessed easily from anywhere. This will slightly increase our apps memory usage but seems like a fair trade off for having easy access to the userConfig from any component which will come in handy for other features in the future.

As for the next episode popup, I've tested playing an episode from a TV library and also using the shuffle function to test the new video player. The next episode popup was successfully suppressed in both cases but when using shuffle play the next episode still played automatically. I believe this is a bug and should be handled in another PR Edit: tested shuffle play on web client with "auto play next ep" turned off and it played more than one episode just like the new player does

@cewert cewert requested a review from 1hitsong March 22, 2023 18:19
@cewert cewert merged commit f427373 into jellyfin:unstable Mar 23, 2023
@cewert cewert deleted the disable-next-episode-popup branch April 14, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next episode popup still appears when "play next episode" is disabled on web client
2 participants