Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Artist & Album view for music library #640

Merged
merged 5 commits into from
Jun 11, 2022
Merged

Create Artist & Album view for music library #640

merged 5 commits into from
Jun 11, 2022

Conversation

1hitsong
Copy link
Member

@1hitsong 1hitsong commented Jun 7, 2022

Changes
Added Artist and Album sorting to the music library, in addition to the default view. Artist view is a list of all known artists in JF as found using MusicArtist item type. Album view is a list of all known albums in JF as found using MusicAlbum item type.

Issues
N/A. This is a New Feature.

@candry7731
Copy link
Contributor

  1. Default view is the artist view, I would remove the "default" option
  2. I would add "songs" view option

@1hitsong
Copy link
Member Author

1hitsong commented Jun 7, 2022

  1. Default view is the artist view, I would remove the "default" option

It's actually a little bit different. The default view displays everything that is a child of the root library. For example, in my library I mostly have artists, but I also have several albums of songs that aren't under an artist. These albums appear in the default view, but under Artist view, they're not shown because they have no artist value.

Perhaps we can change "Default" to something more descriptive to explain the different. Any ideas?

Root? Folder? Base?

  1. I would add "songs" view option

In an effort to keep these PRs smaller than the last, I'm limiting how much I change. Song view will be its own separate change after this.

@candry7731
Copy link
Contributor

I think "Default" is fine. Thanks for the clarification. I didn't notice the no artist albums

Copy link
Contributor

@candry7731 candry7731 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functions as intended.

@jimdogx jimdogx merged commit b6d2303 into jellyfin:master Jun 11, 2022
@1hitsong 1hitsong deleted the music-album-view branch June 11, 2022 23:49
@lakerssuperman
Copy link

Humble user here again. I just updated my Roku with the latest master code, but the artist/album sort ability seems to be gone. The only option under view is "music" and it seems to be a mix of albums with some artists scattered throughout that have multiple albums. Fully possible I'm doing something wrong or looking in the wrong place. Just wanted to clarify that this PR merged the aritst/album sorting into master. Thanks guys!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants