Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Netflix-like scroller section option #1489

Closed
wants to merge 1 commit into from

Conversation

heyhippari
Copy link
Contributor

Changes

Adds a Netflix-like scroller as a home section option which presents the latest 5 items server-wide.

Early implementation, design subject to change. I'm basically only opening this now so I don't forget I have it.

Screenshot_2020-06-26 Jellyfin
Screenshot_2020-06-26 Jellyfin(1)
Screenshot_2020-06-26 Jellyfin

Issues

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hamburglar2160
Copy link

hamburglar2160 commented Jun 26, 2020

Cool!
Consider doubling it to at least 10 items. 5 isn't all that much--HBO uses 12. Can we use the emby scroller through these (perhaps they appear only on mouse-over)? Include the most recent "Continue Watching" item in the mix?

On interfaces that have mouse inputs, perhaps do away with the buttons (and descriptions?) and have them appear on a nice blurhashed mouse-over :)

This would be a very good item to have customizable by the user. Being able to toggle on/off most of the descriptors to match what other streamers use would be very effective as for some (me) less might be more (HBO with that cue). For example, with the top screenshot, something contained within the top- or bottom-left corner of the banner:
"New
Tokyo Monogatari
tagline"

I'm guessing you're leaving music libraries out of this? I think that'd be wise.

#1202
We also have a bunch of good UX references for this posted.

@heyhippari
Copy link
Contributor Author

Consider doubling it to at least 10 items. 5 isn't all that much--HBO uses 12. Can we use the emby scroller through these (perhaps they appear only on mouse-over)? Include the most recent "Continue Watching" item in the mix?

The number will be configurable. As said, this is a very early POC.

It doesn't use the emby-scroller, mostly because that component relies on a severely out of date and unmaintained external dependency that I'd like to remove at some point (The last update for the library it uses is from 2015).
It is using Swiper, the same component used for the photo player and the screensavers.

The slides change every 10 seconds for now (will be configurable as well) and can be manually changed using the bullets at the bottom. They don't slide but fade from one to the next, as a slide would look weird given the visual structure of these.

As for the content, it uses only one endpoint, to get the last few items added to the server. Imo, "continue watching" wouldn't make sense here, since the goal is to showcase items to users. Ideally, we'd hook it up to a suggestion endpoint, but we don't have a good one yet.

On interfaces that have mouse inputs, perhaps do away with the buttons (and descriptions?) and have them appear on a nice blurhashed mouse-over :)

There is no blurhash on this, for now. The goal is to show info to "sell" the new content at glance to the user and act as a showcase for new items. Also we can't blurhash buttons or text, it's only for images, and blurhashing this wouldn't make sense.

This would be a very good item to have customizable by the user. Being able to toggle on/off most of the descriptors to match what other streamers use would be very effective as for some (me) less might be more (HBO with that cue). For example, with the top screenshot, something contained within the top- or bottom-left corner of the banner:
"New
Tokyo Monogatari"

Eventually, my goal is to have every visual element of everything in Jellyfin be configurable in some way. However, this very much requires a complete redesign of the way we handle settings and present them to the user.
Keep in mind that we do multiple passes when designing stuff like this. The details page is a good example of this. The version in 10.5 was early, has some visual inconsistencies and annoyances. Through using it more, we're bringing a few improvements to 10.6, as well as visual fixes and more options for how it behaves. I expect this way of doing things to continue in the future with all the redesigns and new features we introduce.

So see the result of this PR as a first pass, to be improved upon in the future.

I'm guessing you're leaving music libraries out of this? I think that'd be wise.

It uses whatever the LatestItems endpoint returns, we don't really have any control on that aside from passing it library IDs, for now.

@ri0thamus
Copy link

I love this idea. The home page could use a visual change to separate it from the project that it originated from.

@Bitwolfies
Copy link
Contributor

Defiantly a fantastic addition, I do have to ask about it using images for titles, did you manually add those? I don't think jellyfin downloads them as metadata, so im wondering if that will be added too.

@heyhippari
Copy link
Contributor Author

Defiantly a fantastic addition, I do have to ask about it using images for titles, did you manually add those? I don't think jellyfin downloads them as metadata, so im wondering if that will be added too.

It will use the Logo instead of text for the title if there is one. They can be either added manually or automatically through the Fanart plugin.

@Bitwolfies
Copy link
Contributor

Defiantly a fantastic addition, I do have to ask about it using images for titles, did you manually add those? I don't think jellyfin downloads them as metadata, so im wondering if that will be added too.

It will use the Logo instead of text for the title if there is one. They can be either added manually or automatically through the Fanart plugin.

Well that would explain where to get them from, thank you.

@heyhippari heyhippari added the ui & ux This PR or issue mainly concerns UI & UX label Jul 14, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stale
Copy link

stale bot commented Nov 7, 2020

Issues go stale after 90d of inactivity. Mark the issue as fresh by adding a comment or commit. Stale issues close after an additional 14d of inactivity. If this issue is safe to close now please do so. If you have any questions you can reach us on Matrix or Social Media.

@stale stale bot added the stale No activity for an extended length of time label Nov 7, 2020
@dkanada dkanada removed the stale No activity for an extended length of time label Nov 7, 2020
@github-actions github-actions bot added the merge conflict Conflicts prevent merging label Dec 1, 2020
@stale
Copy link

stale bot commented Mar 19, 2021

Issues go stale after 90d of inactivity. Mark the issue as fresh by adding a comment or commit. Stale issues close after an additional 14d of inactivity. If this issue is safe to close now please do so. If you have any questions you can reach us on Matrix or Social Media.

@stale stale bot added the stale No activity for an extended length of time label Mar 19, 2021
@stale stale bot closed this Jun 2, 2021
@MominRaza
Copy link

This is a cool idea
Why this is still not merged or no progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflict Conflicts prevent merging stale No activity for an extended length of time ui & ux This PR or issue mainly concerns UI & UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants