Switch to using web component version of nav bar #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
approved these changes
Oct 16, 2022
|
FWIW I tested this locally in Chrome and there's a bit of delay waiting for the header to load, e.g. the page loads without the header and then it appears, probably should be render blocking? |
|
I'm not really sure how to make it block, I think it's the nature of web components. It caches really well though |
|
Could possibly bundle it in the app? Coming from npm? |
|
Unpkg is a pretty fast cdn and has better support for ESM modules. If you refresh again it's it slow? |
|
Oh wait I see what you mean. The first paint is slow. I can move the script tags to the end and async them |
|
Sure if that helps, created #147 for tracking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it looks like right now
What it looks like with web component:
I realized there's a need to allow sites to extend the nav bar, so i'll add support for it, but I still think its a possible win.