Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web UI to manage board election #96

Merged
merged 1 commit into from
May 12, 2017
Merged

Web UI to manage board election #96

merged 1 commit into from
May 12, 2017

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Nov 7, 2016

Signed-off-by: Nicolas De Loof nicolas.deloof@gmail.com

require some extra configuration parameters:

  • electionCandidates : coma separated list of candidates
  • electionLogfile : path to store collected votes. assume this path is well persisted/backup
  • electionOpen : date app will start collecting votes. yyyy/MM/dd
  • electionClose : date election will close. yyyy/MM/dd

@ndeloof
Copy link
Contributor Author

ndeloof commented Nov 7, 2016

@reviewbybees

@ghost
Copy link

ghost commented Nov 7, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@rtyler
Copy link
Member

rtyler commented Nov 7, 2016

@ndeloof can you update the README or provide additional documentation for how to set up the board candidates, what files go where, etc? That way I will be able to deploy this successfully once the code is wrapped up

@rtyler rtyler closed this Nov 9, 2016
@rtyler rtyler reopened this Nov 9, 2016
Copy link
Member

@rtyler rtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without documentation to manage this, I can't tell whether this code suffices or not 😦

@rtyler
Copy link
Member

rtyler commented Nov 28, 2016

bump

halp

@ndeloof
Copy link
Contributor Author

ndeloof commented Nov 28, 2016

@rtyler see PR description for configuration parameters

@olblak
Copy link
Member

olblak commented Apr 24, 2017

@rtyler What's missing for this PR to be merged?
@ndeloof I added a docker entrypoint to configure accountapp docker image through environment variables. it doesn't configure this PR yet but I can submit a patch if you merge master changes

@rtyler
Copy link
Member

rtyler commented Apr 24, 2017

@olblak The biggest thing that should be done is some manual testing of these changes. Since this repo doesn't really have any tests whatsoever, a manual verification should be done before these are merged.

You're more than welcome to take that task on for me 😄

@daniel-beck daniel-beck removed their assignment Apr 25, 2017
@rtyler rtyler merged commit a1c33f6 into jenkins-infra:master May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants