-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web UI to manage board election #96
Conversation
@reviewbybees |
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof can you update the README or provide additional documentation for how to set up the board candidates, what files go where, etc? That way I will be able to deploy this successfully once the code is wrapped up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without documentation to manage this, I can't tell whether this code suffices or not 😦
@rtyler see PR description for configuration parameters |
@olblak The biggest thing that should be done is some manual testing of these changes. Since this repo doesn't really have any tests whatsoever, a manual verification should be done before these are merged. You're more than welcome to take that task on for me 😄 |
Signed-off-by: Nicolas De Loof nicolas.deloof@gmail.com
require some extra configuration parameters: