Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add configuration through variables + tests #102

Closed
wants to merge 3 commits into from

Conversation

olblak
Copy link
Member

@olblak olblak commented Apr 19, 2017

This PR remove strong dependency on external volumes.
All configuration can be done through env variables
It simplifies application deployment in an environment like kubernetes

Anyway it still work the old way.
We do not generate /etc/config.properties if it's already mounted

	In order to simplify account deployment
	on kubernetes, I want to configure it through
	env variables
@olblak
Copy link
Member Author

olblak commented Apr 19, 2017

It seems that ci.jenkins.io is stuck on the wrong commit (c4563c6)
This commit don't exist anymore.

screenshot from 2017-04-19 11-26-45

@rtyler
Copy link
Member

rtyler commented Apr 19, 2017

@olblak #96 requires a persistent volume to be used. The k8s work will still support that yes?

@olblak
Copy link
Member Author

olblak commented Apr 19, 2017

In order to use #96
I was thinking today to update following projects:

  1. Azure: Add a new shared disk named 'accountapp' within then same storage account than logs with 50Gb allocated
    we can update -> azure project
  2. Accountapp: Configure new variables (electionCandidates, electionLogfile, electionOpen, electionClose) through env variables (with a separated PR)
  3. Jenkins-infra: Add a new kubernetes resource called 'accountapp', with the same approach than Fluentd

@olblak
Copy link
Member Author

olblak commented Apr 19, 2017

In order to run rake test, I use a ruby docker image to run rspec tests.
Part of the tests, is to build and run a docker container in order to check installed packages,files,directories,...
That mean I need to do docker next to docker.
I made the assumption that docker group id is 982 in order to mount and use docker socket within the ruby container

@olblak
Copy link
Member Author

olblak commented Apr 24, 2017

I am closing this PR as I am splitting the content of this PR in several others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants